Implemented: added the functionality to the popover buttons in the mobile view of completed orders page (#244) #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…opover around the popover icon (hotwax#244)
ymaheshwari1
requested changes
Aug 29, 2023
…thub.com/amansinghbais/fulfillment-pwa into fulfillment-pwa/hotwax#244-completedpage
…label with desktop label in completed page (hotwax#244)
… fulfillment-pwa/hotwax#244-completedpage
…thub.com/amansinghbais/fulfillment-pwa into fulfillment-pwa/hotwax#244-completedpage
… fulfillment-pwa/hotwax#244-completedpage
alsoK2maan
suggested changes
Sep 22, 2023
src/views/ShippingPopover.vue
Outdated
| export default defineComponent({ | ||
| name: "ShippingPopover", | ||
| components: { | ||
| IonContent, | ||
| IonItem, | ||
| IonList, | ||
| }, | ||
| props: ['hasPackedShipments', 'order'], | ||
| methods: { | ||
| closeModal(eventName: string) { |
There was a problem hiding this comment.
Suggested change
| closeModal(eventName: string) { | |
| closeModal(selectedMethod: string) { |
src/views/Completed.vue
Outdated
|
|
||
| // Calls method which is clicked on the popover, functions name returns when popover dismiss. | ||
| if(typeof(this[selectedMethod]) === 'function') { | ||
| (this as any)[selectedMethod](order); |
… fulfillment-pwa/hotwax#244-completedpage
… fulfillment-pwa/hotwax#244-completedpage
|
Closing as the UI of the app is getting changed and there is no immediate requirement for mobile view support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Related Issue: #244
Short Description and Why It's Useful
Screenshots of Visual Changes before/after (If There Are Any)
Before
After
IMPORTANT NOTICE - Remember to add changelog entry
Contribution and Currently Important Rules Acceptance